Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(s3-deployment): deploy data with deploy-time values #18659

Merged
merged 19 commits into from
Feb 3, 2022
Merged

feat(s3-deployment): deploy data with deploy-time values #18659

merged 19 commits into from
Feb 3, 2022

Commits on Jan 26, 2022

  1. feat(s3-deployment): deploy content with deploy-time values [WIP] 

    Allow deploying test-based content that can potentially include deploy-time values such as attributes of cloud resources.

Introduce a `Source.content(objectKey, text)` where `text` can naturally include tokens that resolve only at deploy time.
This is implemented by replacing the deploy-time tokens with markers that are replaced inside the s3-deployment custome resource.

Fixes #12903

TODO:

- [ ] Implement + test the custom resource code
- [ ] Documentation
- [ ] Finalize integration test
    Elad Ben-Israel committed Jan 26, 2022
    Configuration menu
    Copy the full SHA
    335c9c8 View commit details
    Browse the repository at this point in the history

Commits on Jan 28, 2022

  1. Addressing case where the content is a single token

    Otavio Macedo committed Jan 28, 2022
    Configuration menu
    Copy the full SHA
    3c61b9b View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2022

  1. add unit tests for python lambda code

    Elad Ben-Israel committed Feb 1, 2022
    Configuration menu
    Copy the full SHA
    9a1def5 View commit details
    Browse the repository at this point in the history

  2. tests, jsonData, and more

    Elad Ben-Israel committed Feb 1, 2022
    Configuration menu
    Copy the full SHA
    2fa4acf View commit details
    Browse the repository at this point in the history

  3. update readme

    Elad Ben-Israel committed Feb 1, 2022
    Configuration menu
    Copy the full SHA
    044003f View commit details
    Browse the repository at this point in the history

  4. integration tests pass

    Elad Ben-Israel committed Feb 1, 2022
    Configuration menu
    Copy the full SHA
    1c8e5ca View commit details
    Browse the repository at this point in the history

  5. cleanups, improved errors and commens

    Elad Ben-Israel committed Feb 1, 2022
    Configuration menu
    Copy the full SHA
    22e8a6c View commit details
    Browse the repository at this point in the history

  6. Merge branch 'master' into benisrae/bucket-deployment-content-source

    Elad Ben-Israel authored Feb 1, 2022
    Configuration menu
    Copy the full SHA
    83d9dca View commit details
    Browse the repository at this point in the history

Commits on Feb 2, 2022

  1. fix backwards compatibility

    Elad Ben-Israel committed Feb 2, 2022
    Configuration menu
    Copy the full SHA
    efce5a9 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'benisrae/bucket-deployment-content-source' of github.co… 

    …m:aws/aws-cdk into benisrae/bucket-deployment-content-source
    Elad Ben-Israel committed Feb 2, 2022
    Configuration menu
    Copy the full SHA
    f707d0c View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into benisrae/bucket-deployment-content-source

    Elad Ben-Israel authored Feb 2, 2022
    Configuration menu
    Copy the full SHA
    5827072 View commit details
    Browse the repository at this point in the history

  4. update integ

    Elad Ben-Israel committed Feb 2, 2022
    Configuration menu
    Copy the full SHA
    9b0283d View commit details
    Browse the repository at this point in the history

  5. re-run integ tests

    Elad Ben-Israel committed Feb 2, 2022
    Configuration menu
    Copy the full SHA
    956a703 View commit details
    Browse the repository at this point in the history

  6. update snapshots

    Elad Ben-Israel committed Feb 2, 2022
    Configuration menu
    Copy the full SHA
    7cf5c49 View commit details
    Browse the repository at this point in the history

  7. Update packages/@aws-cdk/aws-s3-deployment/README.md 

    Co-authored-by: Otavio Macedo <[email protected]>
    @otaviomacedo
    Elad Ben-Israel and otaviomacedo authored Feb 2, 2022
    Configuration menu
    Copy the full SHA
    fd6f3a2 View commit details
    Browse the repository at this point in the history

  8. remove empty source markers

    Elad Ben-Israel committed Feb 2, 2022
    Configuration menu
    Copy the full SHA
    60a3aae View commit details
    Browse the repository at this point in the history

Commits on Feb 3, 2022

  1. Merge branch 'master' into benisrae/bucket-deployment-content-source

    Elad Ben-Israel authored Feb 3, 2022
    Configuration menu
    Copy the full SHA
    3572ab0 View commit details
    Browse the repository at this point in the history

  2. update README

    Elad Ben-Israel committed Feb 3, 2022
    Configuration menu
    Copy the full SHA
    5ea4a07 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into benisrae/bucket-deployment-content-source

    @mergify
    mergify[bot] authored Feb 3, 2022
    Configuration menu
    Copy the full SHA
    f80dd01 View commit details
    Browse the repository at this point in the history