Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(integ-runner): test update path when running tests #19915

Merged
merged 3 commits into from
Apr 14, 2022
Merged

feat(integ-runner): test update path when running tests #19915

merged 3 commits into from
Apr 14, 2022

Commits on Apr 14, 2022

  1. feat(integ-runner): test update path when running tests 

    This PR adds an "update path" workflow to the integration test
workflow. When a change is being made to an existing integration test we
want to be able to ensure that the change not only works for _new_
stacks, but also with _existing_ stacks. In order to accomplish this,
the runner will first deploy the existing snapshot (i.e. `cdk deploy
--app /path/to/snapshot`) and then perform a stack update by deploying
the integration test.

The update path can be disabled by passing the `--disable-update-path`
command line option.

This PR adds a couple of pieces of functionality in order to enable
testing the "update path".

1. The runner will attempt to checkout the snapshot from the origin
   before running the test. This is to try and make sure that you are
   actually testing an update of the existing snapshot and not an
   intermediate snapshot (e.g. if you have been iterating locally).
2. When the runner performs the snapshot diff, it will check for any
   destructive changes and return that information as a warning to the
   user.
3. If any destructive changes are found, the runner will record that
   information as trace metadata in the `manifest.json` file. This will
   enable us to create automation that checks for this as part of the PR
   workflow
    @corymhall
    corymhall committed Apr 14, 2022
    Configuration menu
    Copy the full SHA
    b33a406 View commit details
    Browse the repository at this point in the history

  2. adding logic around allowDestroy

    @corymhall
    corymhall committed Apr 14, 2022
    Configuration menu
    Copy the full SHA
    c7b7968 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into corymhall/integ-runner/update-path

    @mergify
    mergify[bot] authored Apr 14, 2022
    Configuration menu
    Copy the full SHA
    794306d View commit details
    Browse the repository at this point in the history