Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(redshift): adds classic or elastic resize type option #21084

Merged
merged 3 commits into from
Jul 12, 2022

Conversation

daschaa
Copy link
Contributor

@daschaa daschaa commented Jul 10, 2022

Fixes #19430.

Adds the property classicResizing property to the ClusterProps. If not set or set to false, elastic resizing is used.

I feel like an entry in the README is not necessary. If it is ok, please add pr-linter/exempt-readme label to this PR.


All Submissions:

Adding new Unconventional Dependencies:

  • This PR adds new unconventional dependencies following the process described here

New Features

  • Have you added the new feature to an integration test?
    • Did you use yarn integ to deploy the infrastructure and generate the snapshot (i.e. yarn integ without --dry-run)?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Jul 10, 2022

@aws-cdk-automation aws-cdk-automation requested a review from a team July 10, 2022 16:44
@github-actions github-actions bot added p2 effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. labels Jul 10, 2022
Copy link
Contributor

@corymhall corymhall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When would a user want to use classic vs elastic? Without doing some research myself I am not sure. Can you add more information to this docstring to help the user make that decision? Depending on how complicated the answer it it might need a README update.

@mergify mergify bot dismissed corymhall’s stale review July 11, 2022 19:26

Pull request has been modified.

@daschaa
Copy link
Contributor Author

daschaa commented Jul 11, 2022

@corymhall I have added more information to the docstring. I hope it is ok like this :)
Do you think it is worth adding a README section?
I think it could be useful, because the topic is quite complex. Or is it enough to link the official AWS docs there?

Copy link
Contributor

@corymhall corymhall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@corymhall I have added more information to the docstring. I hope it is ok like this :)
Do you think it is worth adding a README section?
I think it could be useful, because the topic is quite complex. Or is it enough to link the official AWS docs there?

Thanks for making the update! I think this is much better! I think for the scope of this PR this is fine, but I'll add a backlog item to add a resizing section to the README since it looks like resizing is pretty complicated.

@corymhall corymhall added pr-linter/exempt-readme The PR linter will not require README changes pr-linter/exempt-integ-test The PR linter will not require integ test changes labels Jul 12, 2022
@mergify
Copy link
Contributor

mergify bot commented Jul 12, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 02b7948
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit b5e9c1a into aws:main Jul 12, 2022
@mergify
Copy link
Contributor

mergify bot commented Jul 12, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2 pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/exempt-readme The PR linter will not require README changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(redshift): specify classic or elastic resize
3 participants