fix(efs): support tagging for access point

[ymhiroki]

Closes #20743 .

---

All Submissions:

• Have you followed the guidelines in our Contributing guide?

Adding new Construct Runtime Dependencies:

• This PR adds new construct runtime dependencies following the process described here

New Features

• Have you added the new feature to an integration test?
• Did you use yarn integ to deploy the infrastructure and generate the snapshot (i.e. yarn integ without --dry-run)?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[aws-cdk-automation]

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

✅ Updated pull request passes all PRLinter validations. Dissmissing previous PRLinter review.

[ymhiroki]

I referred to #7363 and #7445 to add a new tag for EFS::AccessPoint.

I implement it and add tests for aws-efs, however, tags are not generated and tests failed.
Precedent commits are too old and there are little examples about tests.

Do you have any ideas about my mistake?

aws-efs % yarn test
yarn run v1.22.19
$ cdk-test
FAIL test/access-point.test.js
  ● support tags for AccessPoint

    Template has 1 resources with type AWS::EFS::AccessPoint, but none match as expected.
    The 1 closest matches:
    MyAccessPoint9925F14C :: {
      "Properties": {
    !!   Missing key 'AccessPointTags'
        "AccessPointTags": undefined,
        "FileSystemId": { "Ref": "EfsFileSystem37910666" },
        "RootDirectory": {}
      },
      "Type": "AWS::EFS::AccessPoint"
    }

      105 |     const matchError = hasResourceProperties(this.template, type, props);
      106 |     if (matchError) {
    > 107 |       throw new Error(matchError);
          |             ^
      108 |     }
      109 |   }
      110 |

      at Template.hasResourceProperties (../assertions/lib/template.ts:107:13)
      at Object.<anonymous> (test/access-point.test.ts:42:29)

[corymhall]

Do you have any ideas about my mistake?

@ymhiroki looks like you did everything correctly! I'm not sure why it was failing with that error, I just updated the branch so that it would build again and it's working now (just need to update the integ test snapshots).

[TheRealAmazonKendra]

Looks like this will need a few more snapshot updates. Putting this into changes requested to remove from our review queue for the moment.

Pull request has been modified.

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
• Commit ID: 6037d03
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).