fix(core): crossRegionReferences doesn't work when exporting to multiple regions #25190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
multiple regions The cross region export writer was only being given permissions to the first region it would export to. Fixing this by adding each consuming region to the IAM policy. fixes #24464
github-actions
bot
added
bug
otaviomacedo
added
the
pr/do-not-merge
otaviomacedo
approved these changes
Apr 21, 2023
...ib/core/lib/custom-resource-provider/cross-region-export-providers/export-writer-provider.ts
Outdated
Show resolved
Hide resolved
|
|
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
mergify bot
pushed a commit
that referenced
this pull request
May 4, 2023
…25384) The first attempt to fix this in #25190 didn't work because it didn't account for the fact that when exporting to multiple regions, we create multiple `ExportWriter`s that all use the same provider (and provider role). This PR fixes that by adding the policy cross region ARNs directly to the custom resource provider (1 per stack) rather than the `ExportWriter` (multiple per stack). I also updated the test case to better account for this scenario. fixes #25377 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
|
is this fix live in the node aws-cdk library? I ran into this bug but I'm still on aws-cdk 2.60.0 (build 2d40d77). Does this PR being merged mean that it was released? |
yep, it was released in |
|
@corymhall my hero! thx |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cross region export writer was only being given permissions to the first region it would export to. Fixing this by adding each consuming region to the IAM policy.
fixes #24464
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license