Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(app-staging-synthesizer): misleading error message about environment-agnostic/aware stacks #26607

Merged
merged 3 commits into from
Aug 2, 2023
Merged

fix(app-staging-synthesizer): misleading error message about environment-agnostic/aware stacks #26607

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fb6f412
new error message
kaizencc Aug 2, 2023
eb7b6f9
Update packages/@aws-cdk/app-staging-synthesizer-alpha/lib/app-stagin…
kaizencc Aug 2, 2023
c6a2ea1
Merge branch 'main' into conroy/app-synth
mergify[bot] Aug 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/@aws-cdk/app-staging-synthesizer-alpha/lib/app-staging-synthesizer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,8 +257,8 @@ export class AppStagingSynthesizer extends StackSynthesizer implements IReusable
throw new Error([
'It is not safe to use AppStagingSynthesizer for both environment-agnostic and environment-aware stacks at the same time.',
'Please either specify environments for all stacks or no stacks in the CDK App.',
`Stacks with environment: ${describeStacks(agnosticStacks)}.`,
`Stacks without environment: ${describeStacks(envAwareStacks)}.`,
`At least these stacks with environment: ${describeStacks(envAwareStacks)}.`,
`At least these stacks without environment: ${describeStacks(agnosticStacks)}.`,
].join(' '));
}
}
Expand Down