Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(scheduler): disable Schedule on creation #27236

Merged
merged 10 commits into from
Sep 22, 2023
Merged

feat(scheduler): disable Schedule on creation #27236

merged 10 commits into from
Sep 22, 2023

Conversation

MoartnW
Copy link
Contributor

@MoartnW MoartnW commented Sep 21, 2023

Small change to make it possible to disable a Schedule. It basically works the same as in Rule in aws-events.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK label Sep 21, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team September 21, 2023 13:40
@github-actions github-actions bot added the p2 label Sep 21, 2023
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@MoartnW
Copy link
Contributor Author

MoartnW commented Sep 21, 2023

Exemption Request

Not sure what to add to the README file for this change. Also I think integration test is not required here (yet)?

@aws-cdk-automation aws-cdk-automation added the pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. label Sep 21, 2023
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Sep 21, 2023
Copy link
Contributor

@lpizzinidev lpizzinidev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! 💪
I left you a couple of comments for some minor changes.

README changes
You can specify your new attribute in the related README.
For example, adding a new section Disabling Schedules after Grouping Schedules explaining how to use the attribute and the default behavior (with an example).

Integration test
You should be able to implement an integration test in the test folder of the construct by following the specified guidelines.

@MoartnW
Copy link
Contributor Author

MoartnW commented Sep 22, 2023

Thanks for your feedback! I did the proposed code changes, and updated the README file. I will now work on adding the integration test and will update this PR once done.

@aws-cdk-automation aws-cdk-automation dismissed their stale review September 22, 2023 12:14

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

Copy link
Contributor

@lpizzinidev lpizzinidev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job! 🎉
Thanks for the quick changes.
Just a super-minor change on the unit test and then it will be good to go for me.

Copy link
Contributor

@kaizencc kaizencc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution @MoartnW! This looks good to me. However, here's a quick PSA: please create open-source PRs off of a non-main branch, so we're guaranteed to have permission to push to your branch. I'm unsure if it will work this time but we're going to give it a try.

More information here

@kaizencc kaizencc changed the title feat(scheduler): make it possible to disable Schedule feat(scheduler): disable Schedule on creation Sep 22, 2023
@mergify
Copy link
Contributor

mergify bot commented Sep 22, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: b443f62
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 193cd3f into aws:main Sep 22, 2023
9 checks passed
@mergify
Copy link
Contributor

mergify bot commented Sep 22, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2 pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants