feat(eks): add neuron device plugin for Inferentia managed node groups

[freschri]

In an EKS cluster with Inferentia instances, Neuron device plugin is only installed in case of autoscaling groups.
The change expands the logic to managed node groups.

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[aws-cdk-automation]

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
• Commit ID: 7d11e7b
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[kaizencc]

I'm not sure what is going on here re: addNeuronDevicePlugin, and there's not really any additional information for me to figure it out. Is there a linked issue that can provide more background? Can you state more clearly what the intention is of this PR in the PR description? Lastly, what we definitely will need is at least 1 unit test

[freschri]

I'm not sure what is going on here re: addNeuronDevicePlugin, and there's not really any additional information for me to figure it out. Is there a linked issue that can provide more background? Can you state more clearly what the intention is of this PR in the PR description? Lastly, what we definitely will need is at least 1 unit test

You can find a description of what the Neuron device plugin is, in here: https://awsdocs-neuron.readthedocs-hosted.com/en/latest/containers/tutorials/k8s-setup.html (tap on Deploy Neuron...):
"Neuron device plugin exposes Neuron cores & devices to kubernetes as a resource. aws.amazon.com/neuroncore, aws.amazon.com/neurondevice, aws.amazon.com/neuron are the resources that the neuron device plugin registers with the kubernetes. aws.amazon.com/neuroncore is used for allocating neuron cores to the container. aws.amazon.com/neurondevice is used for allocating neuron devices to the container. When neurondevice is used all the cores belonging to the device will be allocated to container."
The device plugin is then required not only when instances are launched in an auto scaling group but also in managed group.

The change is replicating the same logic present in addAutoScalingGroupCapacity, see here:

aws-cdk/packages/aws-cdk-lib/aws-eks/lib/cluster.ts

Line 1786 in 7d11e7b

if (nodeTypeForInstanceType(options.instanceType) === NodeType.INFERENTIA) {

Note that e.g. eksctl takes care of that, see here https://docs.aws.amazon.com/eks/latest/userguide/inferentia-support.html:
"The eksctl utility detects that you are launching a node group with an Inf1 instance type and will start your nodes using one of the Amazon EKS optimized accelerated Amazon Linux AMIs. "

The CDK needs to implement the same behaviour, otherwise managed node groups with Inferentia and Trainium devices will not be fully supported.

[kaizencc]

@freschri I put the exempt-integ-test and exempt-readme labels on your PR but we will definitely need some type of unit test at least before approving this PR

[aws-cdk-automation]

This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week.

[aws-cdk-automation]

This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error.

[aws-cdk-automation]

The pull request linter fails with the following errors:

❌ Features must contain a change to a test file.

PRs must pass status checks before we can provide a meaningful review.

If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing Exemption Request and/or Clarification Request.