-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cloudfront): requirement of domainNames prevents moving a domain name between distributions #29329
Closed
Closed
fix(cloudfront): requirement of domainNames prevents moving a domain name between distributions #29329
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -129,7 +129,7 @@ export interface DistributionProps { | |
* | ||
* If you want to use your own domain name, such as www.example.com, instead of the cloudfront.net domain name, | ||
* you can add an alternate domain name to your distribution. If you attach a certificate to the distribution, | ||
* you must add (at least one of) the domain names of the certificate to this list. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Since this is no longer something required, could you also add a sentence at the end explaining the case where we don't need to provide a domain name? |
||
* you should add (at least one of) the domain names of the certificate to this list. | ||
* | ||
* @default - The distribution will only support the default generated name (e.g., d111111abcdef8.cloudfront.net) | ||
*/ | ||
|
@@ -318,10 +318,6 @@ export class Distribution extends Resource implements IDistribution { | |
if (!Token.isUnresolved(certificateRegion) && certificateRegion !== 'us-east-1') { | ||
throw new Error(`Distribution certificates must be in the us-east-1 region and the certificate you provided is in ${certificateRegion}.`); | ||
} | ||
|
||
if ((props.domainNames ?? []).length === 0) { | ||
throw new Error('Must specify at least one domain name to use a certificate with a distribution'); | ||
} | ||
} | ||
|
||
const originId = this.addOrigin(props.defaultBehavior.origin); | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.