fix: use LoggingConfig.LogGroupName when lambda is configured with custom log groups #29450
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Closes #29448
Reason for this change
After the release of Advanced Logging Controls for Lambda (see https://aws.amazon.com/blogs/compute/introducing-advanced-logging-controls-for-aws-lambda-functions/) I've decided to move all the logs of my multi-stack deployment to a single unified Log Group per deployed tenant.
It goes likes this:
The main stack creates the LogGroup like
/aws/lambda/{tenant}
;The secondary stacks refers to the LogGroup using
LogGroup.fromLogGroupArn(...)
;Then I discovered that running cdk watch on the main stack I can see the cloudwatch logs on my terminal while on the secondary stacks it does not;
I found at that the cloudwatch log group resolver for the logs basically just assumes the log group is
/aws/lambda/{physicalId}
https:/aws/aws-cdk/blob/main/packages/aws-cdk/lib/api/logs/find-cloudwatch-logs.ts#L114
Description of changes
Use the Template JSON to resolve the
LoggingConfig.LogGroupName
of the Lambda Function;Description of how you validated changes
Not yet;
Checklist