Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(pipes-sources): add Kinesis and DynamoDB #29476

Merged
merged 46 commits into from
Sep 26, 2024
Merged

feat(pipes-sources): add Kinesis and DynamoDB #29476

merged 46 commits into from
Sep 26, 2024

Conversation

msambol
Copy link
Contributor

@msambol msambol commented Mar 14, 2024 •
edited
Loading

Closes #29378, #29377.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the star-contributor [Pilot] contributed between 25-49 PRs to the CDK label Mar 14, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team March 14, 2024 02:45
@github-actions github-actions bot added feature-request A feature should be added or improved. p2 labels Mar 14, 2024
aws-cdk-automation
aws-cdk-automation previously requested changes Mar 14, 2024
View reviewed changes
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@msambol msambol force-pushed the pipes-kinesis-stream-source branch 2 times, most recently from d101e30 to 5775e19 Compare March 14, 2024 02:48
@msambol msambol changed the title feat(pipes-sources): Kinesis source feat(pipes-sources): add Kinesis source Mar 14, 2024
@aws-cdk-automation aws-cdk-automation dismissed their stale review March 14, 2024 02:49

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Mar 14, 2024
@msambol msambol changed the title feat(pipes-sources): add Kinesis source feat(pipes-sources): add Kinesis and DynamoDB sources Mar 15, 2024
@msambol msambol force-pushed the pipes-kinesis-stream-source branch from 5404f66 to 0760175 Compare March 16, 2024 14:18
@msambol msambol changed the title feat(pipes-sources): add Kinesis and DynamoDB sources feat(pipes-sources): add Kinesis and DynamoDB Mar 16, 2024
@github-actions github-actions bot mentioned this pull request Mar 18, 2024
Closed
@msambol
Copy link
Contributor Author

msambol commented Mar 22, 2024

@nmussy Feel like reviewing a big one? 😄

@nmussy
Copy link
Contributor

nmussy commented Mar 23, 2024

I'll have a look on Monday 👍

nmussy
nmussy suggested changes Mar 25, 2024
View reviewed changes
Copy link
Contributor

@nmussy nmussy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still need to take a look at the tests, but I already went through the code and docs 👍

packages/@aws-cdk/aws-pipes-sources-alpha/lib/deadLetterConfig.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-pipes-sources-alpha/lib/deadLetterConfig.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-pipes-sources-alpha/lib/dynamodb.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-pipes-sources-alpha/lib/dynamodb.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-pipes-sources-alpha/lib/dynamodb.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-pipes-sources-alpha/lib/kinesis.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-pipes-sources-alpha/lib/dynamodb.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-pipes-sources-alpha/lib/kinesis.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-pipes-sources-alpha/lib/kinesis.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-pipes-sources-alpha/lib/kinesis.ts Outdated Show resolved Hide resolved
@msambol msambol force-pushed the pipes-kinesis-stream-source branch 2 times, most recently from 3c66072 to 89b108b Compare March 27, 2024 04:09
@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Mar 27, 2024
@msambol msambol force-pushed the pipes-kinesis-stream-source branch from cbf852d to 50dbcec Compare March 28, 2024 17:28
@msambol
Copy link
Contributor Author

msambol commented Sep 26, 2024

@GavinZZ Thanks for the review! I know this is a large one.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: ecba4fa
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

GavinZZ
GavinZZ approved these changes Sep 26, 2024
View reviewed changes
Copy link
Contributor

@GavinZZ GavinZZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for the effort and patience!

@mergify Mergify
Copy link
Contributor

mergify bot commented Sep 26, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 00c2efb into aws:main Sep 26, 2024
10 checks passed
@github-actions GitHub Actions
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 26, 2024
@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Sep 26, 2024
@msambol msambol deleted the pipes-kinesis-stream-source branch September 26, 2024 23:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@acjay acjay acjay left review comments

@nmussy nmussy nmussy approved these changes

@RaphaelManke RaphaelManke RaphaelManke left review comments

@TheRealAmazonKendra TheRealAmazonKendra TheRealAmazonKendra left review comments

@redwheeler3 redwheeler3 redwheeler3 left review comments

@GavinZZ GavinZZ GavinZZ approved these changes

@aws-cdk-automation aws-cdk-automation aws-cdk-automation left review comments

Assignees
No one assigned
Labels
feature-request A feature should be added or improved. p2 star-contributor [Pilot] contributed between 25-49 PRs to the CDK
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(pipes-sources): Add Kinesis stream source for EventBridge pipes