fix(elasticloadbalancerV2): consistent logicalId for addTargetGroups (under feature flag) #29712
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convention is that
ListenerRule
s should have a logicalId with aRule
suffix. Follow convention while providing a feature flag to support people who already have resources deployed and need to stick with the legacy naming convention.Issue
Closes #29496
Related to PR #29513
Reason for this change
Going forward, the
logicalId
produced should be consistent.Description of changes
Made logicalId consistent by default while providing a feature flag to enable backwards compat for apps which have pre-deployed infra.
Description of how you validated changes
UTs applied.
Exemption Request
: ITs are not required per docsChecklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license