-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cli): template created during import should be written to assets folder #29830
Merged
Merged
Changes from 23 commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
c332aff
fix: import should write overrideTemplate to assembly.outdir
nburtsev 8d73b83
Merge branch 'main' into main
nburtsev b91e06a
Merge branch 'main' into fix/cdk-import-template-path
nburtsev 8b5e5cb
fix: update cli import test to ensure template tiss larger than 50kb
nburtsev 16f3529
Merge branch 'main' into fix/cdk-import-template-path
nburtsev b798c93
Merge branch 'main' into fix/cdk-import-template-path
nburtsev 3f3f730
Merge branch 'main' into fix/cdk-import-template-path
nburtsev de6d0da
Merge branch 'main' into fix/cdk-import-template-path
nburtsev de09c72
Merge branch 'main' into fix/cdk-import-template-path
nburtsev 72af4a2
Merge branch 'main' into fix/cdk-import-template-path
nburtsev 8578e9f
Merge branch 'main' of github.com:aws/aws-cdk into fix/cdk-import-tem…
bergjaak 84a9409
Merge branch 'main' into fix/cdk-import-template-path
bergjaak 75a5dcb
in progress
bergjaak c520676
made test actually work
bergjaak ca4607e
Merge branch 'main' of github.com:aws/aws-cdk into fix/cdk-import-tem…
bergjaak 69cbad7
Merge branch 'main' of github.com:aws/aws-cdk into fix/cdk-import-tem…
bergjaak 06a62be
Merge branch 'main' of github.com:aws/aws-cdk into fix/cdk-import-tem…
bergjaak a6f2c82
made test pass
bergjaak d6f4308
test
colifran 7157944
remove test comment
colifran 02fd882
Merge branch 'fix/cdk-import-template-path' of https:/nbu…
bergjaak 0261c0a
Merge branch 'main' of github.com:aws/aws-cdk into fix/cdk-import-tem…
bergjaak bd0eb88
fix failing tests
bergjaak fa109b3
use cfn fixture
bergjaak 75918ac
fix test again
bergjaak 7e3b24e
remove duplicate line
bergjaak 2cb9614
improve test comments
bergjaak f5cc882
Merge branch 'main' into fix/cdk-import-template-path
mergify[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed that
fixture
has its own CFN client, so I should use that instead of this, probably.