fix(elasticloadbalancingv2): crossZoneEnabled does not support false for ALB #29907
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue # (if applicable)
Closes #29866
Reason for this change
crossZoneEnabled
is not well handled when it'sfalse
with ALB. Because:false
, it will not pass down to the L1 and won't throw any error as ALB does not support being disabled. It just silently ignore it.false
for NLB, the L1 attribute will beundefined
, which is having the same result but it should be explicitly set asfalse
in L1.This PR covers the following cases:
crossZoneEnabled
istrue
,load_balancing.cross_zone.enabled
should betrue
.crossZoneEnabled
isfalse
,load_balancing.cross_zone.enabled
should befalse
, rather thanundefined
.crossZoneEnabled
isfalse
with ALB, cdk throws an error because ALB does not support disabling it per doc description.true
orfalse
.undefined
for ALB or NLB.crossZoneEnabled
prop.Description of changes
Description of how you validated changes
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license