Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(s3): update documentation for more context around autoDeleteObjects #30096

Merged
merged 10 commits into from
May 10, 2024

Conversation

SankyRed
Copy link
Contributor

@SankyRed SankyRed commented May 7, 2024

Issue # (if applicable)

29873

Description of changes

This the documentation update to notify users that upon setting the autoDeleteObjects to true we would also add a new policy s3:PutBucketPolicy to handle race conditions.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team May 7, 2024 20:52
@github-actions github-actions bot added the p2 label May 7, 2024
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label May 7, 2024
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@SankyRed SankyRed changed the title docs(s3):update documentation for more context around autoDeleteObjects docs:update documentation for more context around autoDeleteObjects May 7, 2024
@SankyRed SankyRed changed the title docs:update documentation for more context around autoDeleteObjects docs: update documentation for more context around autoDeleteObjects May 7, 2024
@aws-cdk-automation aws-cdk-automation dismissed their stale review May 7, 2024 20:58

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@SankyRed SankyRed changed the title docs: update documentation for more context around autoDeleteObjects docs(s3): update documentation for more context around autoDeleteObjects May 7, 2024
Copy link
Contributor

@colifran colifran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comment. We need to give more context behind why the s3:PutBucketPolicy is being added.

@SankyRed
Copy link
Contributor Author

SankyRed commented May 8, 2024

See my comment. We need to give more context behind why the s3:PutBucketPolicy is being added.

Updated the readme to provide more context around why the policy is being added. Please take a look when you get some time @colifran

@SankyRed SankyRed marked this pull request as ready for review May 8, 2024 15:12
@SankyRed SankyRed added the pr/do-not-merge This PR should not be merged at this time. label May 8, 2024
@SankyRed SankyRed requested a review from colifran May 9, 2024 14:22
@colifran
Copy link
Contributor

colifran commented May 9, 2024

A few verbiage suggestions and then this will be good to go.

@SankyRed
Copy link
Contributor Author

SankyRed commented May 9, 2024

A few verbiage suggestions and then this will be good to go.

Updated the docs, thanks @colifran

@SankyRed SankyRed requested a review from colifran May 9, 2024 19:30
@SankyRed SankyRed removed the pr/do-not-merge This PR should not be merged at this time. label May 10, 2024
Copy link
Contributor

mergify bot commented May 10, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 1dcc318
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit c377c34 into main May 10, 2024
12 checks passed
@mergify mergify bot deleted the SankyRed/s3-doc-update branch May 10, 2024 16:48
Copy link
Contributor

mergify bot commented May 10, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one.

@aws aws locked as resolved and limited conversation to collaborators Jul 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
contribution/core This is a PR that came from AWS. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants