Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(lambda): adding Insight version #30466

Merged
merged 13 commits into from
Jun 27, 2024
Merged

chore(lambda): adding Insight version #30466

merged 13 commits into from
Jun 27, 2024

Conversation

watany-dev
Copy link
Contributor

Issue # (if applicable)

None.

Reason for this change

https://docs.aws.amazon.com/AmazonCloudWatch/latest/monitoring/Lambda-Insights-extension-versionsx86-64.html
https://docs.aws.amazon.com/AmazonCloudWatch/latest/monitoring/Lambda-Insights-extension-versionsARM.html

Description of changes

  • adding region
    • ap-southeast-4
    • il-central-1
  • adding version
    • Version 1.0.273.0
    • Version 1.0.275.0
    • Version 1.0.295.0
    • Version 1.0.317.0

Description of how you validated changes

no

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the p2 label Jun 6, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team June 6, 2024 07:53
@github-actions github-actions bot added the distinguished-contributor [Pilot] contributed 50+ PRs to the CDK label Jun 6, 2024
@xazhao xazhao self-assigned this Jun 6, 2024
@xazhao
Copy link
Contributor

xazhao commented Jun 7, 2024

Hello it looks like some tests need to be updated to fix the build.

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jun 7, 2024
@watany-dev
Copy link
Contributor Author

@xazhao
Thanks for the comment, it seems the snapshot test was missing.

xazhao
xazhao reviewed Jun 7, 2024
View reviewed changes
packages/aws-cdk-lib/region-info/build-tools/fact-tables.ts
'ap-southeast-2': 'arn:aws:lambda:ap-southeast-2:580247275435:layer:LambdaInsightsExtension:49',
'ap-northeast-1': 'arn:aws:lambda:ap-northeast-1:580247275435:layer:LambdaInsightsExtension:76',
'ca-central-1': 'arn:aws:lambda:ca-central-1:580247275435:layer:LambdaInsightsExtension:48',
// 'ca-west-1': 'arn:aws:lambda:ca-west-1:946466191631:layer:LambdaInsightsExtension:9',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this version commented out?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a region not covered by the current region-info. I am leaving this as a reminder as I am sure it will be addressed in the near future.

xazhao
xazhao reviewed Jun 7, 2024
View reviewed changes
packages/aws-cdk-lib/region-info/build-tools/fact-tables.ts
'ap-southeast-2': 'arn:aws:lambda:ap-southeast-2:580247275435:layer:LambdaInsightsExtension:52',
'ap-northeast-1': 'arn:aws:lambda:ap-northeast-1:580247275435:layer:LambdaInsightsExtension:79',
'ca-central-1': 'arn:aws:lambda:ca-central-1:580247275435:layer:LambdaInsightsExtension:51',
// 'ca-west-1': 'arn:aws:lambda:ca-west-1:946466191631:layer:LambdaInsightsExtension:12',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here: why this insight version is not available?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a region not covered by the current region-info. I am leaving this as a reminder as I am sure it will be addressed in the near future.

@github-actions github-actions bot mentioned this pull request Jun 10, 2024
Closed
@watany-dev watany-dev requested a review from xazhao June 15, 2024 05:49
xazhao
xazhao previously approved these changes Jun 19, 2024
View reviewed changes
@mergify Mergify
Copy link
Contributor

mergify bot commented Jun 19, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jun 19, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Jun 19, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot dismissed xazhao’s stale review June 24, 2024 18:43

Pull request has been modified.

@xazhao
Copy link
Contributor

xazhao commented Jun 27, 2024

@Mergifyio update

@mergify Mergify
Copy link
Contributor

mergify bot commented Jun 27, 2024

update

❌ Mergify doesn't have permission to update

For security reasons, Mergify can't update this pull request. Try updating locally.
GitHub response: refusing to allow a GitHub App to create or update workflow .github/workflows/issue-label-assign.yml without workflows permission

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jun 27, 2024
paulhcsun
paulhcsun approved these changes Jun 27, 2024
View reviewed changes
Copy link
Contributor

@paulhcsun paulhcsun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Mergifyio update

@mergify Mergify
Copy link
Contributor

mergify bot commented Jun 27, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jun 27, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Jun 27, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 56ef3bb
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 06d2742 into aws:main Jun 27, 2024
9 checks passed
@mergify Mergify
Copy link
Contributor

mergify bot commented Jun 27, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@watany-dev watany-dev deleted the arm-lambda-insight branch June 27, 2024 23:50
@github-actions github-actions bot mentioned this pull request Jul 1, 2024
Closed
@aws-cdk-automation
Copy link
Collaborator

Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one.

@aws aws locked as resolved and limited conversation to collaborators Jul 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@paulhcsun paulhcsun paulhcsun approved these changes

@xazhao xazhao xazhao left review comments

Assignees

@xazhao xazhao

Labels
distinguished-contributor [Pilot] contributed 50+ PRs to the CDK p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@watany-dev @xazhao @aws-cdk-automation @paulhcsun