Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ec2): add g6 instance #30693

Merged
merged 4 commits into from
Jul 18, 2024
Merged

feat(ec2): add g6 instance #30693

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3a0f17f
(fix): add ec2 g6 instance
Jun 27, 2024
217712f
Merge branch 'aws:main' into ec2_g6_support
mellevanderlinde Jun 27, 2024
8b98e21
(fix): add ec2 g6 instance
Jun 27, 2024
d793ce5
Merge branch 'main' into ec2_g6_support
scanlonp Jul 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions packages/aws-cdk-lib/aws-ec2/lib/instance-types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -890,6 +890,16 @@ export enum InstanceClass {
*/
G5G = 'g5g',

/**
* Graphics-optimized instances, 6th generation
*/
GRAPHICS6 = 'graphics6',

/**
* Graphics-optimized instances, 6th generation
*/
G6 = 'g6',

/**
* Parallel-processing optimized instances, 2nd generation
*/
Expand Down Expand Up @@ -1568,6 +1578,8 @@ export class InstanceType {
[InstanceClass.G5]: 'g5',
[InstanceClass.GRAPHICS5_GRAVITON2]: 'g5g',
[InstanceClass.G5G]: 'g5g',
[InstanceClass.GRAPHICS6]: 'g6',
[InstanceClass.G6]: 'g6',
[InstanceClass.PARALLEL2]: 'p2',
[InstanceClass.P2]: 'p2',
[InstanceClass.PARALLEL3]: 'p3',
Expand Down
2 changes: 1 addition & 1 deletion packages/aws-cdk-lib/aws-ec2/test/instance.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ describe('instance', () => {
});
test('instance architecture is correctly discerned for x86-64 instance', () => {
// GIVEN
const sampleInstanceClasses = ['c5', 'm5ad', 'r5n', 'm6', 't3a', 'r6i', 'r6a', 'p4de', 'p5', 'm7i-flex']; // A sample of x86-64 instance classes
const sampleInstanceClasses = ['c5', 'm5ad', 'r5n', 'm6', 't3a', 'r6i', 'r6a', 'g6', 'p4de', 'p5', 'm7i-flex']; // A sample of x86-64 instance classes

for (const instanceClass of sampleInstanceClasses) {
// WHEN
Expand Down