Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(pipelines): fix link for originarl API document in README #30852

Merged
merged 4 commits into from
Jul 16, 2024
Merged

docs(pipelines): fix link for originarl API document in README #30852

merged 4 commits into from
Jul 16, 2024

Conversation

mazyu36
Copy link
Contributor

@mazyu36 mazyu36 commented Jul 15, 2024

Fixed a broken link.

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the star-contributor [Pilot] contributed between 25-49 PRs to the CDK label Jul 15, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team July 15, 2024 01:25
@github-actions github-actions bot added the p2 label Jul 15, 2024
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jul 15, 2024
ChakshuGupta13
ChakshuGupta13 reviewed Jul 15, 2024
View reviewed changes
packages/aws-cdk-lib/pipelines/README.md Outdated
`aws-codepipeline`, we recommend you drop down to using the `aws-codepipeline`
`aws-codepipeline`, we recommend you drop down to using the `aws-codepipeline`
Copy link
Contributor

@ChakshuGupta13 ChakshuGupta13 Jul 15, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this change is unrelated and unnecessary (for commit objective), right? if yes, then shall this be removed from this PR?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ChakshuGupta13
Thank you. Unnecessary spaces were automatically deleted.
I reverted it.​​​​​​​​​​​​​​​​

scanlonp
scanlonp previously approved these changes Jul 15, 2024
View reviewed changes
Copy link
Contributor

@scanlonp scanlonp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice update, appreciate it!

@mergify Mergify
Copy link
Contributor

mergify bot commented Jul 15, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jul 15, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Jul 15, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify Mergify
Copy link
Contributor

mergify bot commented Jul 15, 2024

update

❌ Mergify doesn't have permission to update

For security reasons, Mergify can't update this pull request. Try updating locally.
GitHub response: refusing to allow a GitHub App to create or update workflow .github/workflows/issue-label-assign.yml without workflows permission

@mergify mergify bot dismissed scanlonp’s stale review July 16, 2024 00:05

Pull request has been modified.

@mazyu36
Copy link
Contributor Author

mazyu36 commented Jul 16, 2024 •
edited
Loading

@scanlonp
Thank you for the approval. The following error occurred, so I referred to the approaches from past PRs and merged main into this branch.
Could you please approve again?
Also, since I don't fully understand the error content, please let me know if my approach was incorrect.

IMG_3319

@mazyu36 mazyu36 requested a review from scanlonp July 16, 2024 00:35
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jul 16, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Jul 16, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jul 16, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Jul 16, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 01f1675
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 030500a into aws:main Jul 16, 2024
9 checks passed
@mergify Mergify
Copy link
Contributor

mergify bot commented Jul 16, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mazyu36 mazyu36 deleted the pipeline-typo branch July 17, 2024 22:49
@github-actions github-actions bot mentioned this pull request Jul 22, 2024
Closed
@aws-cdk-automation
Copy link
Collaborator

Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one.

@aws aws locked as resolved and limited conversation to collaborators Jul 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ChakshuGupta13 ChakshuGupta13 ChakshuGupta13 approved these changes

@scanlonp scanlonp scanlonp approved these changes

Assignees
No one assigned
Labels
p2 star-contributor [Pilot] contributed between 25-49 PRs to the CDK
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mazyu36 @aws-cdk-automation @ChakshuGupta13 @scanlonp