Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow assumeRoleAction to be set #31129

Closed

Conversation

RichardoC
Copy link

Issue #31128

Closes #31128

Reason for this change

This is required for using OIDC to assume an AWS role, this should be sts:AssumeRoleWithWebIdentity in this case

Description of changes

Default assumeRoleAction to 'sts:AssumeRole' for backwards compatibility, but allow it to be overridden if needed

Description of how you validated changes

Added custom assumeRoleAction to 'can use all role properties'

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

This is required for using OIDC to assume an AWS role, this should be sts:AssumeRoleWithWebIdentity in this case
@github-actions github-actions bot added beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK bug This issue is a bug. p2 labels Aug 16, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team August 16, 2024 10:07
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@RichardoC RichardoC changed the title Allow assumeRoleAction to be set fix: allow assumeRoleAction to be set Aug 16, 2024
@aws-cdk-automation
Copy link
Collaborator

The pull request linter fails with the following errors:

❌ Fixes must contain a change to an integration test file and the resulting snapshot.

PRs must pass status checks before we can provide a meaningful review.

If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing Exemption Request and/or Clarification Request.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 9077fdd
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@RichardoC
Copy link
Author

Not needed, can be done via #31128 (comment)

@RichardoC RichardoC closed this Aug 16, 2024
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK bug This issue is a bug. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws-iam: Unable to use sts:AssumeRoleWithWebIdentity to assume a role
2 participants