add unit tests for s3 static website origin #31207
Conversation
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
| id: 'StackOrigin12AB34569', | ||
| domainName: bucket.bucketWebsiteDomainName, | ||
| customOriginConfig: { | ||
| originSslProtocols: ['TLSv1.2'], |
There was a problem hiding this comment.
If S3 website endpoint support HTTP only and not HTTPS, why do we need this originSslProtocols and what would it do?
There was a problem hiding this comment.
Good point. We don't need it but it's currently set by default in the constructor for HttpOrigin here. It does not have any effect on the deployment though and the origin protocol policy is correctly set as HTTP only.
| }, | ||
| ], | ||
| }); | ||
| }); |
There was a problem hiding this comment.
Should we have a test case for using imported bucket? to make sure the code works, no errors, setting props correctly etc.
|
The pull request linter fails with the following errors: PRs must pass status checks before we can provide a meaningful review. If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing |
|
Comments on closed issues and PRs are hard for our team to see. |
Changes:
S3StaticWebsiteOriginwith default and custom propsChecklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license