Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update cli integ tests to use sdk v3 #31226

Merged
merged 7 commits into from
Aug 29, 2024
Merged

chore: update cli integ tests to use sdk v3 #31226

merged 7 commits into from
Aug 29, 2024

Conversation

TheRealAmazonKendra
Copy link
Contributor

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team August 26, 2024 23:36
@github-actions github-actions bot added the p2 label Aug 26, 2024
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Aug 26, 2024
aws-cdk-automation
aws-cdk-automation previously requested changes Aug 26, 2024
View reviewed changes
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@TheRealAmazonKendra TheRealAmazonKendra force-pushed the TheRealAmazonKendra/cli-integ-tests-sdk branch from 72b5675 to 059f2d3 Compare August 28, 2024 18:06
@TheRealAmazonKendra TheRealAmazonKendra force-pushed the TheRealAmazonKendra/cli-integ-tests-sdk branch from 059f2d3 to d3e7f22 Compare August 28, 2024 18:11
TheRealAmazonKendra
TheRealAmazonKendra commented Aug 28, 2024
View reviewed changes
packages/@aws-cdk-testing/cli-integ/tests/cli-integ-tests/cli.integtest.ts
}),
);

integTest(
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Somehow the old and new version of this test ended up in the last update. OOPS. Removing the old flaky one here.

@TheRealAmazonKendra
Copy link
Contributor Author

Sent to the testing pipeline. Will leave listed as WIP until I've verified that succeeds.

@TheRealAmazonKendra TheRealAmazonKendra force-pushed the TheRealAmazonKendra/cli-integ-tests-sdk branch from d3e7f22 to 72b5675 Compare August 29, 2024 06:11
@TheRealAmazonKendra TheRealAmazonKendra changed the title WIP: chore: update cli integ tests to use sdk v3 chore: update cli integ tests to use sdk v3 Aug 29, 2024
@aws-cdk-automation aws-cdk-automation dismissed their stale review August 29, 2024 17:35

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@TheRealAmazonKendra TheRealAmazonKendra force-pushed the TheRealAmazonKendra/cli-integ-tests-sdk branch from 72b5675 to 3964cd2 Compare August 29, 2024 17:50
@TheRealAmazonKendra
Copy link
Contributor Author

This has succeeded in the test pipeline a few times but I've pushed it with the rebase once again just to cover all my bases.

@TheRealAmazonKendra
Copy link
Contributor Author

Ooops. Then rebased it incorrectly.

@aws-cdk-automation
Copy link
Collaborator

➡️ PR build request submitted to test-main-pipeline ⬅️

A maintainer must now check the pipeline and add the pr-linter/cli-integ-tested label once the pipeline succeeds.

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Aug 29, 2024
@TheRealAmazonKendra
Copy link
Contributor Author

Passed the pipeline again.

scanlonp
scanlonp requested changes Aug 29, 2024
View reviewed changes
Copy link
Contributor

@scanlonp scanlonp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Committing these changes.

packages/@aws-cdk-testing/cli-integ/lib/staging/codeartifact.ts Outdated Show resolved Hide resolved
packages/@aws-cdk-testing/cli-integ/lib/staging/codeartifact.ts Outdated Show resolved Hide resolved
packages/@aws-cdk-testing/cli-integ/lib/staging/codeartifact.ts Outdated Show resolved Hide resolved
packages/@aws-cdk-testing/cli-integ/lib/staging/codeartifact.ts Outdated Show resolved Hide resolved
@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Aug 29, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Aug 29, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 8ec93d0
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 2a27711 into main Aug 29, 2024
10 of 12 checks passed
@mergify Mergify
Copy link
Contributor

mergify bot commented Aug 29, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot deleted the TheRealAmazonKendra/cli-integ-tests-sdk branch August 29, 2024 22:43
@github-actions GitHub Actions
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@scanlonp scanlonp scanlonp approved these changes

@aws-cdk-automation aws-cdk-automation aws-cdk-automation left review comments

Assignees
No one assigned
Labels
contribution/core This is a PR that came from AWS. p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TheRealAmazonKendra @aws-cdk-automation @scanlonp