Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stream Manager Client Logger Type Incorrectly Specified #19

Open
lummish opened this issue Jan 20, 2021 · 0 comments · May be fixed by #20
Open

Stream Manager Client Logger Type Incorrectly Specified #19

lummish opened this issue Jan 20, 2021 · 0 comments · May be fixed by #20

Comments

@lummish
Copy link

lummish commented Jan 20, 2021

Description

Currently, the Logger type defined here does not match the interface expected by the StreamManagerClient. It is missing the property warn.
lummish added a commit to automotus/aws-greengrass-core-sdk-js that referenced this issue Jan 20, 2021
@lummish
Correctly Specify StreamManagerClient Logger Type
c1ab248 
StreamManagerClient expects an optional Logger within its constructor.
The Logger type definition does not include a property `warn`, which is
expected by the StreamManagerClient.

This commit adds a property `warn` to the JSDoc typedef for
StreamManagerClient's Logger to reduce the likelihood of users supplying
an invalid Logger.

Resolves aws#19
@lummish lummish linked a pull request Jan 20, 2021 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Correctly Specify StreamManagerClient Logger Type automotus/aws-greengrass-core-sdk-js
1 participant
@lummish