-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug: sam build can't check the JVM version on gradle >= v8.9 #682
Comments
jeffryang24
added
the
stage/needs-triage
Automatically applied to new issues and PRs, indicating they haven't been looked at.
label
Sep 5, 2024
Forwarded from aws/aws-sam-cli#7446. |
Hi @jeffryang24, thanks for reporting the bug and opening a PR to fix it. |
hnnasit
added
type/bug
area/workflow/java_gradle
and removed
stage/needs-triage
Automatically applied to new issues and PRs, indicating they haven't been looked at.
labels
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description:
Previously,
sam build
does not show this warning message when building using Gradle, but somehow this message appears in the new Gradle version.Steps to reproduce:
sam build
on existing SAM application project.Observed result:
Got above error message while the build process is successfully executed.
Expected result:
Don't show above error message since the JVM version should be available from
gradlew -v
command.Additional environment details (Ex: Windows, Mac, Amazon Linux etc)
After testing with older Gradle version (below v8.8), found out the gradle output for JVM has different label.
JVM
label,Launcher JVM
orDaemon JVM
label.Gradle < v8.9
Use gradle v8.8 as example, current sam-cli integration test is using v8.4.
Gradle >= v8.9
Use gradle v8.9 as example.
Root Cause
Probably, we need to update the
startswith
validation from this line,aws-lambda-builders/aws_lambda_builders/workflows/java_gradle/gradle_validator.py
Line 86 in be29a9f
sam --version
: 1.123.0Add --debug flag to command you are running
The text was updated successfully, but these errors were encountered: