Restore file permissions after unzip #401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
pr/external
stage/needs-triage
jfuss
requested changes
Nov 10, 2022
| LOG = logging.getLogger(__name__) | ||
|
|
||
|
|
||
| def _is_symlink(file_info): |
There was a problem hiding this comment.
Can you move this into the OSUtils instead of global scope?
It would be useful to have a comment and link to the code in SAM CLI. Just helps future people know we copied it from one place to the other.
There was a problem hiding this comment.
Yeah, I assume you want all the new methods inside OSUtils then? Is that right? I'll add the comment and a link to the code in SAM CLI
…re it was copied from
jfuss
approved these changes
Nov 10, 2022
mndeveci
approved these changes
Nov 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Because of this issue, files coming back from Amazon.Lambda.Tools were not getting the same permissions after unzipping. In the case where we want to
sam local invokeon a custom runtime, this means we'll get a permission error since the unzipped files don't have execute permissions. This uses the code from SAM CLI to set permissions correctly.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.