fix: streaming stderr from subprocess started by lambda-builders #563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
pr/external
stage/needs-triage
mndeveci
reviewed
Oct 24, 2023
lucashuy
reviewed
Oct 24, 2023
hawflau
reviewed
Oct 24, 2023
| @@ -66,6 +66,12 @@ def run(self, args, cwd=None): | |||
| self.osutils.remove_directory(check_dir) | |||
| else: | |||
| # Bundler has relevant information in stdout, not stderr. | |||
There was a problem hiding this comment.
Should we update this comment too? Seems not accurate anymore
hnnasit
removed
the
stage/needs-triage
lucashuy
approved these changes
Oct 26, 2023
hawflau
approved these changes
Oct 26, 2023
mndeveci
requested changes
Oct 26, 2023
mndeveci
approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#6068
Description of changes:
the stderr output of the subprocess was being ignored and because of this if there was no information in stdout all that a user would see was that the bundler failed.
This fix has the bundler output the stderr from the subprocess if it fails.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.