Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: build requirements.txt pointing to private repository #581

Merged
merged 4 commits into from
Dec 5, 2023
Merged

fix: build requirements.txt pointing to private repository #581

merged 4 commits into from
Dec 5, 2023

Conversation

sidhujus
Copy link
Contributor

@sidhujus sidhujus commented Dec 1, 2023

Issue #, if available:
#253
Description of changes:
Instead of relying on what is returned by sys.executable always use the version of python that has pip to execute the command

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@github-actions github-actions bot added pr/external stage/needs-triage Automatically applied to new issues and PRs, indicating they haven't been looked at. area/workflow/python_pip and removed pr/external stage/needs-triage Automatically applied to new issues and PRs, indicating they haven't been looked at. labels Dec 1, 2023
@sidhujus sidhujus marked this pull request as ready for review December 1, 2023 23:33
@sidhujus sidhujus requested a review from a team as a code owner December 1, 2023 23:33
mndeveci
mndeveci approved these changes Dec 5, 2023
View reviewed changes
Copy link
Contributor

@mndeveci mndeveci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Minor comment to add some explanation why we are using sys.executable in the functional tests.

tests/functional/workflows/python_pip/test_packager.py Show resolved Hide resolved
@sidhujus sidhujus added this pull request to the merge queue Dec 5, 2023
Merged via the queue into aws:develop with commit 95c5502 Dec 5, 2023
141 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hawflau hawflau hawflau approved these changes

@mndeveci mndeveci mndeveci approved these changes

@lucashuy lucashuy Awaiting requested review from lucashuy lucashuy is a code owner automatically assigned from aws/serverless-application-experience-sbt

@hnnasit hnnasit Awaiting requested review from hnnasit hnnasit is a code owner automatically assigned from aws/serverless-application-experience-sbt

Assignees
No one assigned
Labels
area/workflow/python_pip
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sidhujus @hawflau @mndeveci