fix: specify glibc version when building with cargo lambda for provided.al2 #640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
pr/external
stage/needs-triage
sidhujus
added
pr/internal
and removed
pr/external
stage/needs-triage
8 tasks
lucashuy
reviewed
Apr 29, 2024
jysheng123
approved these changes
Apr 29, 2024
lucashuy
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
cargo lambda builds with a higher version of glibc now as of this pr cargo-lambda/cargo-lambda#563
so in order to avoid breaking customers using a
provided.al2runtime we must specify the correct glibc version through the--targetflag used bycargo lambdaBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.