Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update appveyor images #4943

Merged
merged 34 commits into from
Mar 29, 2023
Merged

chore: update appveyor images #4943

merged 34 commits into from
Mar 29, 2023

Conversation

mndeveci
Copy link
Contributor

Updates Appveyor images to Ubuntu2004 for Linux and Visual Studio 2022 for Windows.
For Linux job definition;

  • It uses bundled python installations rather than installing them via apt-get install
  • Since local python installations have pip in them, we don't need to install them at all
  • Since all the tests runs on the same image, these changes removes redundant condition for each test where it had image: Ubuntu
  • Since all python versions runs smoke tests, it removes the environment variable and redundant if statement for the test run

For Windows job definition;

  • TestInitCommand::test_graceful_exit test method got stuck while trying to kill the running process. That test is already been verified during GHA, so it is disabled for Appveyor/Windows runners.

Test run for Linux: https://ci.appveyor.com/project/AWSSAMCLI/aws-sam-cli-canary-linux-dev/builds/46631919
Test runs for Windows:

Mandatory Checklist

PRs will only be reviewed after checklist is complete

  • Add input/output type hints to new functions/methods
  • Write design document if needed (Do I need to write a design document?)
  • Write/update unit tests
  • Write/update integration tests
  • Write/update functional tests if needed
  • make pr passes
  • make update-reproducible-reqs if dependencies were changed
  • Write documentation

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mndeveci mndeveci requested a review from a team as a code owner March 29, 2023 07:18
@moelasmar moelasmar added this pull request to the merge queue Mar 29, 2023
Merged via the queue into develop with commit fd834f1 Mar 29, 2023
@mndeveci mndeveci deleted the update_appveyor_images branch April 19, 2023 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants