fix: terraform go permission integration testing failure #4970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… library modules imports
…raform # Conflicts: # samcli/local/lambdafn/zip.py # samcli/local/layers/layer_downloader.py
…raform # Conflicts: # tests/integration/buildcmd/test_build_terraform_applications_other_cases.py # tests/integration/testdata/buildcmd/terraform/go_lambda_function_check_keep_permissions/main.tf
mildaniel
reviewed
Apr 5, 2023
| @@ -310,10 +310,10 @@ def test_invoke_function(self): | |||
|
|
|||
| _, stderr, return_code = self.run_command(build_cmd_list, env=environment_variables) | |||
| LOG.info(stderr) | |||
| self.assertNotEqual(return_code, 0) | |||
| self.assertEqual(return_code, 0) | |||
There was a problem hiding this comment.
Why did this assertion flip?
There was a problem hiding this comment.
It was a mistake, we need to make sure that the build is successful
mildaniel
approved these changes
Apr 5, 2023
lucashuy
approved these changes
Apr 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why is this change necessary?
To fix the failing integration test case
tests/integration/buildcmd/test_build_terraform_applications_other_cases.py::TestBuildGoFunctionAndKeepPermissions::test_invoke_functionHow does it address the issue?
I fixed the test cases asserting, and the building scripts for windows environment.
Mandatory Checklist
PRs will only be reviewed after checklist is complete
make prpassesmake update-reproducible-reqsif dependencies were changedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.