feat: Generate sam validate and sam package schema
#5559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
pr/external
stage/needs-triage
lucashuy
approved these changes
Jul 20, 2023
| "resolve_s3": { | ||
| "title": "resolve_s3", | ||
| "type": "boolean", | ||
| "description": "Automatically resolve AWS S3 bucket for non-guided deployments. Enabling this option will also create a managed default AWS S3 bucket for you. If one does not provide a --s3-bucket value, the managed bucket will be used. Do not use --guided with this option." |
There was a problem hiding this comment.
Do not use --guided with this option.
I'm guessing this comes from the deploy command (or rather the option was written with the deploy command in mind and we are reusing it here)
There was a problem hiding this comment.
Yup, that seems to be the case. It uses a decorator method to produce the resolve_s3 click option, and the help text seems specifically catered to deploy. We could change that text if need be, to be more specific about "If running with deploy, do not use --guided", but I don't think it's completely necessary.
hnnasit
approved these changes
Jul 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change, the schema for
sam validateandsam packagewill be added to the JSON schema. It will serve to validate the parameters in samconfig for thevalidateandpackagecommands.Mandatory Checklist
PRs will only be reviewed after checklist is complete
make prpassesmake update-reproducible-reqsif dependencies were changedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.