fix: Add type names to custom parameter types #5620
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why is this change necessary?
Since the SAM CLI uses custom types without names, we had to create a constant to map the name of the parameter to its set of possible values. This creates additional overhead when creating new custom parameter types.
How does it address the issue?
The
name
fields of each of these types have now been populated, and as such, they are able to be read by the schema parser. This means we can include the expected type (or types) of the parameter to be read.What side effects does this change have?
The
name
field of each SAM CLI custom type has been populated instead of being an empty string (not that it was being used to begin with).Mandatory Checklist
PRs will only be reviewed after checklist is complete
make pr
passesmake update-reproducible-reqs
if dependencies were changedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.