Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Generate sam logs schema #5638

Merged
merged 2 commits into from
Jul 28, 2023
Merged

Conversation

Leo10Gama
Copy link
Member

@Leo10Gama Leo10Gama commented Jul 27, 2023

With this change, the schema for sam logs will be added to the JSON schema. It will serve to validate the parameters in samconfig for the logs command.

Mandatory Checklist

PRs will only be reviewed after checklist is complete

  • Add input/output type hints to new functions/methods
  • Write design document if needed (Do I need to write a design document?)
  • Write/update unit tests
  • Write/update integration tests
  • Write/update functional tests if needed
  • make pr passes
  • make update-reproducible-reqs if dependencies were changed
  • Write documentation

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@Leo10Gama Leo10Gama requested a review from a team as a code owner July 27, 2023 21:24
@github-actions github-actions bot added pr/external stage/needs-triage Automatically applied to new issues and PRs, indicating they haven't been looked at. area/schema JSON schema file and removed pr/external stage/needs-triage Automatically applied to new issues and PRs, indicating they haven't been looked at. labels Jul 27, 2023
@lucashuy lucashuy enabled auto-merge (squash) July 28, 2023 17:38
@lucashuy lucashuy merged commit a3429e3 into aws:feat/json-schema Jul 28, 2023
73 checks passed
@Leo10Gama Leo10Gama deleted the logs-schema branch July 28, 2023 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/schema JSON schema file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants