Skip to content

Commit

Permalink
backfill @required on imagebuilder#LaunchTemplateConfiguration.SetDef…
Browse files Browse the repository at this point in the history
…aultVersion (#2838)
  • Loading branch information
lucix-aws authored Oct 16, 2024
1 parent 04e7aca commit 09f35b4
Show file tree
Hide file tree
Showing 6 changed files with 19 additions and 7 deletions.
8 changes: 8 additions & 0 deletions .changelog/139b04a8d6124cb29dfb9e66f9f70386.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
{
"id": "139b04a8-d612-4cb2-9dfb-9e66f9f70386",
"type": "bugfix",
"description": "**BREAKING CHANGE**: The type of LaunchTemplateConfiguration.SetDefaultVersion has been changed from `bool` to `*bool`. Before this change, the field was incorrectly marked as having a default value of false by the service, which made it functionally impossible for users to express the full range of values for the field (true, false, and unset/nil), each of which have distinctly different behaviors.",
"modules": [
"service/imagebuilder"
]
}
Original file line number Diff line number Diff line change
Expand Up @@ -54,4 +54,4 @@ private static Map.Entry<ShapeId, Set<ShapeId>> serviceToShapeIds(String service
ShapeId.from(serviceId),
Arrays.stream(shapeIds).map(ShapeId::from).collect(toSet()));
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,11 @@ public class RemoveDefaults implements GoIntegration {
serviceToShapeIds("com.amazonaws.paymentcryptographydata#PaymentCryptographyDataPlane",
"com.amazonaws.paymentcryptographydata#IntegerRangeBetween4And12"),
serviceToShapeIds("com.amazonaws.emrserverless#AwsToledoWebService",
"com.amazonaws.emrserverless#WorkerCounts"));
"com.amazonaws.emrserverless#WorkerCounts"),
serviceToShapeIds("com.amazonaws.imagebuilder#imagebuilder",
// https:/aws/aws-sdk-go-v2/issues/2734
// V1479153907
"com.amazonaws.imagebuilder#LaunchTemplateConfiguration$setDefaultVersion"));

private boolean mustPreprocess(ShapeId service) {
return toRemove.containsKey(service);
Expand Down Expand Up @@ -95,4 +99,4 @@ private static Map.Entry<ShapeId, Set<ShapeId>> serviceToShapeIds(String service
ShapeId.from(serviceId),
Arrays.stream(shapeIds).map(ShapeId::from).collect(Collectors.toSet()));
}
}
}
2 changes: 1 addition & 1 deletion service/imagebuilder/deserializers.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions service/imagebuilder/serializers.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion service/imagebuilder/types/types.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 09f35b4

Please sign in to comment.