-
Notifications
You must be signed in to change notification settings - Fork 632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trailing #
in sso_start_url
stripped when parsing shared config files
#2369
Labels
bug
This issue is a bug.
needs-triage
This issue or PR still needs to be triaged.
p1
This is a high priority issue
Comments
gdavison
added
bug
This issue is a bug.
needs-triage
This issue or PR still needs to be triaged.
labels
Nov 16, 2023
This was referenced Nov 16, 2023
This was referenced Nov 16, 2023
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
This issue is a bug.
needs-triage
This issue or PR still needs to be triaged.
p1
This is a high priority issue
Describe the bug
The SSO Start URLs generated by IAM Identity Center include a trailing
#
, for examplehttps://d-123456789a.awsapps.com/start#
. This trailing#
is stripped by the parser for shared configuration files.When used with legacy non-refreshable credentials (https://docs.aws.amazon.com/cli/latest/userguide/sso-configure-profile-legacy.html), the SSO Start URL is used to generate the token file name (
aws-sdk-go-v2/credentials/ssocreds/sso_credentials_provider.go
Line 98 in 435199f
#
is stripped, the file names are different.Expected Behavior
I would be able to successfully authenticate with a legacy SSO configuration
Current Behavior
I am not able to authenticate, and get an error which contains
Reproduction Steps
Add the following files to
internal/ini/testdata/valid
start_url
start_url_expected
Run the acceptance test
TestValidDataFiles
The result is
Possible Solution
No response
Additional Information/Context
No response
AWS Go SDK V2 Module Versions Used
github.com/aws/aws-sdk-go-v2/internal/ini v1.7.0
Compiler and Version used
go version go1.21.0 darwin/arm64
Operating System and version
macOS 13.4.1
The text was updated successfully, but these errors were encountered: