Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for dualStackIPv6 ECS account setting #2772

Closed
2 tasks
diogoazevedos opened this issue Sep 3, 2024 · 2 comments
Closed
2 tasks

Add support for dualStackIPv6 ECS account setting #2772

diogoazevedos opened this issue Sep 3, 2024 · 2 comments
Assignees
Labels
bug This issue is a bug. p2 This is a standard priority issue service-api This issue is due to a problem in a service API, not the SDK implementation.

Comments

@diogoazevedos
Copy link

Describe the feature

Add support for dualStackIPv6 ECS account setting.

Use Case

Enable dualStackIPv6 using Terraform aws_ecs_account_setting_default.

Proposed Solution

I think it's matter of adding the dualStackIPv6 to:

// Enum values for SettingName
const (
SettingNameServiceLongArnFormat SettingName = "serviceLongArnFormat"
SettingNameTaskLongArnFormat SettingName = "taskLongArnFormat"
SettingNameContainerInstanceLongArnFormat SettingName = "containerInstanceLongArnFormat"
SettingNameAwsvpcTrunking SettingName = "awsvpcTrunking"
SettingNameContainerInsights SettingName = "containerInsights"
SettingNameFargateFipsMode SettingName = "fargateFIPSMode"
SettingNameTagResourceAuthorization SettingName = "tagResourceAuthorization"
SettingNameFargateTaskRetirementWaitPeriod SettingName = "fargateTaskRetirementWaitPeriod"
SettingNameGuardDutyActivate SettingName = "guardDutyActivate"
)
// Values returns all known values for SettingName. Note that this can be expanded
// in the future, and so it is only as up to date as the client.
//
// The ordering of this slice is not guaranteed to be stable across updates.
func (SettingName) Values() []SettingName {
return []SettingName{
"serviceLongArnFormat",
"taskLongArnFormat",
"containerInstanceLongArnFormat",
"awsvpcTrunking",
"containerInsights",
"fargateFIPSMode",
"tagResourceAuthorization",
"fargateTaskRetirementWaitPeriod",
"guardDutyActivate",
}
}

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

AWS Go SDK V2 Module Versions Used

None

Go version used

1.23.0

@diogoazevedos diogoazevedos added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Sep 3, 2024
@bhavya2109sharma bhavya2109sharma self-assigned this Sep 4, 2024
@bhavya2109sharma bhavya2109sharma added bug This issue is a bug. service-api This issue is due to a problem in a service API, not the SDK implementation. p2 This is a standard priority issue and removed feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Sep 4, 2024
@bhavya2109sharma
Copy link
Contributor

Hello @diogoazevedos

I've looked into your issue and can confirm that the enum is not being correctly modeled by the service team. This has also been reported by other SDK customers.

There is an existing internal ticket (P146481495) with the EC2 service team to update their model with the missing enum. Since the AWS SDKs are code-generated from these API models, the SDK team cannot add the missing enum directly. The service team will need to make the change on the backend.

As a workaround, you can directly pass the string value instead of using the enum. This is already documented here, so you can use the string value and it should work as expected.

Since this is a duplicate, Im going to close this issue and ask you to track the existing one for updates.

Thanks
~Bhavya

Copy link

github-actions bot commented Sep 4, 2024

This issue is now closed. Comments on closed issues are hard for our team to see.
If you need more assistance, please open a new issue that references this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug. p2 This is a standard priority issue service-api This issue is due to a problem in a service API, not the SDK implementation.
Projects
None yet
Development

No branches or pull requests

2 participants