service/s3: Add support for regional S3 us-east-1 endpoint #2938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasdel
added
the
needs-review
jasdel
force-pushed
the
feat/S3RegionalEndpoint
branch
from
a0eed1e
to
8be689c
Compare
skmcgrail
reviewed
Nov 12, 2019
jasdel
force-pushed
the
feat/S3RegionalEndpoint
branch
2 times, most recently
from
55ad05e
to
6ab3363
Compare
skmcgrail
approved these changes
Nov 12, 2019
jasdel
force-pushed
the
feat/S3RegionalEndpoint
branch
from
6ab3363
to
99eacad
Compare
skmcgrail
approved these changes
Nov 14, 2019
Adds support for S3 configuring an SDK Amazon S3 client for the regional us-east-1 endpoint instead of the default global s3 endpoint. Adds a new configuration option, `S3UsEast1RegionalEndpoint` which when set to RegionalS3UsEast1Endpoint, and region is `us-east-1` the S3 client will resolve the `us-east-1` regional endpoint, `s3.us-east-1.amazonaws.com` instead of the global S3 endpoint, `s3.amazonaws.com`. The SDK defaults to the current global S3 endpoint resolution for backwards compatibility. Opt-in to the `us-east-1` regional endpoint via the SDK's Config, environment variable, `AWS_S3_US_EAST_1_REGIONAL_ENDPOINT=regional`, or shared config option, `s3_us_east_1_regional_endpoint=regional`. Note the SDK does not support the shared configuration file by default. You must opt-in to that behavior via Session Option `SharedConfigState`, or `AWS_SDK_LOAD_CONFIG=true` environment variable.
jasdel
force-pushed
the
feat/S3RegionalEndpoint
branch
from
99eacad
to
26036b8
Compare
jasdel
removed
the
needs-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for S3 configuring an SDK Amazon S3 client for the regional us-east-1 endpoint instead of the default global s3 endpoint.
Adds a new configuration option,
S3UsEast1RegionalEndpointwhich when set to RegionalS3UsEast1Endpoint, and region isus-east-1the S3 client will resolve theus-east-1regional endpoint,s3.us-east-1.amazonaws.cominstead of the global S3 endpoint,s3.amazonaws.com. The SDK defaults to the current global S3 endpoint resolution for backwards compatible.Opt-in to the
us-east-1regional endpoint via the SDK's Config, environment variable,AWS_S3_US_EAST_1_REGIONAL_ENDPOINT=regional, or shared config option,s3_us_east_1_regional_endpoint=regional.Note the SDK does not support the shared configuration file by default. You must opt-in to that behavior via Session Option
SharedConfigState, orAWS_SDK_LOAD_CONFIG=trueenvironment variable.