Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

catalog.add_column() without column_comment triggers exception #1017

Closed
gvogel-hh opened this issue Nov 18, 2021 · 1 comment · Fixed by #1018
Closed

catalog.add_column() without column_comment triggers exception #1017

gvogel-hh opened this issue Nov 18, 2021 · 1 comment · Fixed by #1018
Labels
bug Something isn't working minor release Will be addressed in the next minor release ready to release
Milestone
2.13.0

Comments

@gvogel-hh
Copy link

Describe the bug

In wr.catalog.add_column(), leaving column_comment unset raises an exception:

botocore.exceptions.ParamValidationError: Parameter validation failed:
Invalid type for parameter TableInput.StorageDescriptor.Columns[3].Comment, value: None, type: <class 'NoneType'>, valid types: <class 'str'>

Documentation says that the default value None is acceptable as well.

Environment

awswrangler==2.12.1

To Reproduce

wr.catalog.add_column(database="a", table="b", column_name="c", column_type="string")
@gvogel-hh gvogel-hh added the bug Something isn't working label Nov 18, 2021
@kukushking kukushking mentioned this issue Nov 18, 2021
Merged
@jaidisido
Copy link
Contributor

Thanks for raising, fixed by PR #1018 and available in the next release

@kukushking kukushking added this to the 2.13.0 milestone Nov 18, 2021
@kukushking kukushking linked a pull request Nov 18, 2021 that will close this issue
Fix None column comment #1018
Merged
@kukushking kukushking added minor release Will be addressed in the next minor release ready to release labels Nov 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working minor release Will be addressed in the next minor release ready to release
Projects
None yet
Milestone
2.13.0
Development

Successfully merging a pull request may close this issue.

Fix None column comment aws/aws-sdk-pandas
3 participants
@kukushking @jaidisido @gvogel-hh