Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Athena UNLOAD #1038

Merged
merged 9 commits into from
Jan 6, 2022
Merged

Add Athena UNLOAD #1038

merged 9 commits into from
Jan 6, 2022

Conversation

kukushking
Copy link
Contributor

*Issue #1015 *

Description of changes:
Add UNLOAD

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jaidisido
Copy link
Contributor

AWS CodeBuild CI Report

  • CodeBuild project: GitHubCodeBuild8756EF16-pDO66x4b9gEu
  • Commit ID: f9dfb13
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@jaidisido
Copy link
Contributor

AWS CodeBuild CI Report

  • CodeBuild project: GitHubCodeBuild8756EF16-pDO66x4b9gEu
  • Commit ID: ae8192a
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@jaidisido
Copy link
Contributor

AWS CodeBuild CI Report

  • CodeBuild project: GitHubCodeBuild8756EF16-pDO66x4b9gEu
  • Commit ID: 7ed9227
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@jaidisido
Copy link
Contributor

AWS CodeBuild CI Report

  • CodeBuild project: GitHubCodeBuild8756EF16-pDO66x4b9gEu
  • Commit ID: 8f88eb8
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@lucasmo
Copy link

lucasmo commented Dec 17, 2021

Hi! Really excited this is getting worked on.

Would it make sense to change the error messages here to suggest either a ctas or unload approach? https:/awslabs/aws-data-wrangler/blob/42b46f67c3e651d6a9847d216a0257fca4eabe7c/awswrangler/athena/_utils.py#L211

@kukushking kukushking marked this pull request as ready for review December 22, 2021 17:46
@jaidisido
Copy link
Contributor

AWS CodeBuild CI Report

  • CodeBuild project: GitHubCodeBuild8756EF16-pDO66x4b9gEu
  • Commit ID: 65bd6c7
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@kukushking
Copy link
Contributor Author

kukushking commented Dec 23, 2021 •
edited
Loading

Thanks @lucasmo - corrected the error message. Feel free to try out the unload by:

pip uninstall awswrangler -y
pip install git+https:/awslabs/aws-data-wrangler.git@feat-athena-unload

@kukushking kukushking mentioned this pull request Dec 23, 2021
Closed
jaidisido
jaidisido requested changes Jan 5, 2022
View reviewed changes
Copy link
Contributor

@jaidisido jaidisido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great overall, just a few nitpicks. Excited about this one, thank you!

awswrangler/athena/_read.py Outdated Show resolved Hide resolved
awswrangler/athena/_read.py Show resolved Hide resolved
tests/test_athena.py Outdated Show resolved Hide resolved
@jaidisido
Copy link
Contributor

AWS CodeBuild CI Report

  • CodeBuild project: GitHubCodeBuild8756EF16-pDO66x4b9gEu
  • Commit ID: a42d4cf
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@jaidisido jaidisido merged commit 4cb7f73 into main Jan 6, 2022
@jaidisido jaidisido deleted the feat-athena-unload branch January 6, 2022 14:15
This was linked to issues Jan 6, 2022
CTAS x data source x cross-account x structured fields #1034
Closed
athena.read_sql_query support for UNLOAD instead of CTAS #1015
Closed
@kukushking kukushking self-assigned this Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaidisido jaidisido jaidisido requested changes

Assignees

@kukushking kukushking

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@kukushking @jaidisido @lucasmo