Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify athena2quicksight datatypes to allow startswith for varchar #1332

Merged
merged 1 commit into from
May 13, 2022
Merged

Modify athena2quicksight datatypes to allow startswith for varchar #1332

merged 1 commit into from
May 13, 2022

Conversation

jaidisido
Copy link
Contributor

Feature or Bugfix

  • Bugfix

Detail

  • Modify athena2quicksight datatypes to allow startswith for varchar

Relates

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jaidisido jaidisido self-assigned this May 12, 2022
@jaidisido jaidisido added the bug Something isn't working label May 12, 2022
@jaidisido jaidisido added this to the 2.16.0 milestone May 12, 2022
@jaidisido jaidisido linked an issue May 12, 2022 that may be closed by this pull request
quicksight.create_athena_dataset errors when varchar has specified length #1331
Closed
@jaidisido
Copy link
Contributor Author

AWS CodeBuild CI Report

  • CodeBuild project: GitHubCodeBuild8756EF16-pDO66x4b9gEu
  • Commit ID: b7b3b0d
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

kukushking
kukushking approved these changes May 12, 2022
View reviewed changes
Copy link
Contributor

@kukushking kukushking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be great to have a test case, too

@jaidisido jaidisido merged commit ef0f83a into main May 13, 2022
@jaidisido jaidisido deleted the issue-1331-bug-varchar-athenaquicksight-types branch May 13, 2022 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kukushking kukushking kukushking approved these changes

@cnfait cnfait Awaiting requested review from cnfait

@malachi-constant malachi-constant Awaiting requested review from malachi-constant

Assignees

@jaidisido jaidisido

Labels
bug Something isn't working
Projects
None yet
Milestone
2.16.0
Development

Successfully merging this pull request may close these issues.

quicksight.create_athena_dataset errors when varchar has specified length
2 participants
@jaidisido @kukushking