Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[aws-for-fluent-bit] Add serviceAccount.annotations parameter to README #622

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

espizo
Copy link

@espizo espizo commented Oct 24, 2021

Issue

#395

Description of changes

Updated README.md with the following changes:

Checklist

  • Added/modified documentation as required (such as the README.md for modified charts)
  • Incremented the chart version in Chart.yaml for the modified chart(s)
  • Manually tested. Describe what testing was done in the testing section below
  • Make sure the title of the PR is a good description that can go into the release notes

Testing

This functionality already exists, so I verified that it works with:

helm upgrade --install aws-for-fluent-bit eks/aws-for-fluent-bit \
    --namespace kube-system \
    --set serviceAccount.annotations."eks\.amazonaws\.com/role-arn"="dummy-role-arn"

And then:

$ kubectl get serviceaccount aws-for-fluent-bit -n kube-system -o yaml | head -n5
apiVersion: v1
kind: ServiceAccount
metadata:
  annotations:
    eks.amazonaws.com/role-arn: dummy-role-arn

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

@hossain-rayhan hossain-rayhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@espizo espizo changed the title [aws-for-fluent-bit] Add serviceAccount.create parameter to README [aws-for-fluent-bit] Add serviceAccount. annotations parameter to README Oct 25, 2021
@espizo espizo changed the title [aws-for-fluent-bit] Add serviceAccount. annotations parameter to README [aws-for-fluent-bit] Add serviceAccount. annotations parameter to README Oct 25, 2021
@espizo espizo changed the title [aws-for-fluent-bit] Add serviceAccount. annotations parameter to README [aws-for-fluent-bit] Add serviceAccount.annotations parameter to README Nov 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants