Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[aws-for-fluent-bit] User should be able to provide an existing fluent-bit configmap #743

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

AntonAleksandrov13
Copy link

@AntonAleksandrov13 AntonAleksandrov13 commented Apr 28, 2022

Issue

Description of changes

We are migrating from fluent-bit installation made based on EKS deployment guide. This article creates a set of custom fluent-bit configs which are not easy to migrate considering how fluent-bit populated now. I believe that a user should be able to provide own configmap with custom configurations.

Checklist

  • Added/modified documentation as required (such as the README.md for modified charts)
  • Incremented the chart version in Chart.yaml for the modified chart(s)
  • Manually tested. Describe what testing was done in the testing section below
  • Make sure the title of the PR is a good description that can go into the release notes

Testing

helm upgrade --install aws-for-fluent-bit ./ - creates a managed cm and mounts the cm

helm upgrade --install aws-for-fluent-bit --set existingConfigMapName=my-custom-cm ./ - mounts an existing cm

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@AntonAleksandrov13 AntonAleksandrov13 changed the title [aws-for-fluent-bit] User should be able to provide a custom cm using override [aws-for-fluent-bit] User should be able to provide an existing fluent-bit configmap Apr 28, 2022
@PettitWesley
Copy link
Contributor

@AntonAleksandrov13 If you provide your own config map, what's the value of using this chart? If you have your own config already set in a config map, I'd just setup my own daemonset with that config... why not do that?

@AntonAleksandrov13
Copy link
Author

@PettitWesley I do agree that providing completely custom config might be a bit too much, so the chart is losing it's value. However, the current setup is limiting and restrictive. For example adding lua functions for datetime conversion is not possible as far as I can tell.

I can rework my PR to fit your structure a bit more and fit needed functionality. Would that work for you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants