Add support for configuring tags included with auto created log groups #778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to created log groups
choppedpork
requested review from
PettitWesley and
hossain-rayhan
as code owners
stable/aws-for-fluent-bit/README.md
Outdated
| @@ -56,6 +56,7 @@ helm delete aws-for-fluent-bit --namespace kube-system | |||
| | `cloudWatch.logFormat` | An optional parameter that can be used to tell CloudWatch the format of the data. A value of json/emf enables CloudWatch to extract custom metrics embedded in a JSON payload. See the Embedded Metric Format. | | | |||
| | `cloudWatch.roleArn` | ARN of an IAM role to assume (for cross account access). | | | |||
| | `cloudWatch.autoCreateGroup` | Automatically create the log group. Valid values are "true" or "false" (case insensitive). | true | | |||
| | `cloudWatch.newLogGroupTags` | Tags to include with auto created log groups. Map of key/value pairs. | {} | | |||
There was a problem hiding this comment.
Can you edit this slightly to make it even more clear- what you have right now is good, but let's say explicitly it only works if you set auto_create_group true and the log group did not already exist.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
n/a
Description of changes
I've added the ability to set the
new_log_group_tagsoption value for Fluent Bit Plugin for CloudWatch Logs. I'm currently starting work on migrating away from the FluentD CloudWatch implementation and this is the only bit of functionality I'm missing - it's already supported by the plugin itself, just not the chart.Checklist
README.mdfor modified charts)versioninChart.yamlfor the modified chart(s)Testing
I've tested this change by deploying the helm chart to a test cluster, verifying the Fluent Bit logs and checking the tags on log groups in CloudWatch. Note that contrary to the README of the plugin itself I had to skip the double quotes as otherwise I was getting the following error back from the API:
My test tag set didn't not include spaces however I've ran an additional test with spaces in the tag value and it's all worked great!
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.