Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pod labels updated to include app.kubernetes.io/version #980

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

jw-maynard
Copy link

@jw-maynard jw-maynard commented Aug 3, 2023

Issue

Description of changes

I would like to see the app version added to pods as a label. In addition I moved the merging of selectorLabels into the podLabels out of the deployment and into a new helper.

I'd be curious if merging additionalLabels into the podLabels would also be a good idea since the description of additionalLabels says they are added to all components but that doesn't include the pods created by the deployment. Perhaps that is intentional.

Also, I copied the code for app.kubernetes.io/managed-by which will default to Helm but perhaps that should be removed since technically the pod is managed by the deployment which is managed by Helm...

Checklist

  • Added/modified documentation as required (such as the README.md for modified charts)
  • Incremented the chart version in Chart.yaml for the modified chart(s)
  • Manually tested. Describe what testing was done in the testing section below
  • Make sure the title of the PR is a good description that can go into the release notes

Testing

None, the test scripts seem to only be helpers. It's a pretty small change though.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jw-maynard jw-maynard marked this pull request as ready for review August 3, 2023 21:29
@jw-maynard
Copy link
Author

@kishorj @M00nF1sh are there any changes I need to make here?

@jw-maynard
Copy link
Author

Anything that needs to be done here to get this checked and merged?

@jw-maynard
Copy link
Author

@kishorj @M00nF1sh any thoughts on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant