Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep Java dependencies in sync with the KCL V2.4.4 #202

Merged
merged 1 commit into from
Jan 3, 2023

Conversation

zengyu714
Copy link
Contributor

@zengyu714 zengyu714 commented Jan 3, 2023

Issue #, if available:

Description of changes:

  • Updated dependencies to match the v2.4.4 KCL Java release
  • Updated slfj to resolve the logger's incompatibility problem:
    class org.slf4j.impl.SimpleLoggerFactory cannot be cast to class ch.qos.logback.classic.LoggerContext     \
    (org.slf4j.impl.SimpleLoggerFactory and ch.qos.logback.classic.LoggerContext are in unnamed module of loader 'app')
    

Testing

  • npm test
  • sample producer and consumer

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

@shanmsac shanmsac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zengyu714 zengyu714 changed the title Keep Java dependencies in sync with the KCLV2.4.4 Keep Java dependencies in sync with the KCL V2.4.4 Jan 3, 2023
@zengyu714 zengyu714 merged commit 6336ba3 into awslabs:master Jan 3, 2023
@zengyu714 zengyu714 deleted the up-master branch January 3, 2023 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants