Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KCL does not appear to catch JsonParseException, halting operation of thread #270

Closed
andrewrosezen opened this issue Nov 17, 2017 · 2 comments
Labels

Comments

@andrewrosezen
Copy link

From logstash-plugins/logstash-input-kinesis#35 (comment)

I've been experiencing an occasional situation in which the KCL stops attempting to retrieve messages from specified kinesis streams, and the only way I've been able to get the clients to resume has been via restarting them. It was mentioned in the referenced issue that this could be due to the KCL not catching JsonParseException and backing off.

@pfifer
Copy link
Contributor

pfifer commented Dec 18, 2017

I responded on the linked issue. This doesn't appear to be an issue with the KCL as JsonParseException is a checked exception which would need to be converted to a RuntimeException before being thrown from a method that doesn't declare the exception in its signature. The conversion occurs within the AWS Java SDK.

It's possible the problems you are seeing are related to #185.

@pfifer
Copy link
Contributor

pfifer commented Feb 21, 2018

I'm going to close this, feel free to reopen if you have any more questions.

@pfifer pfifer closed this as completed Feb 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants