Extract the native component without copying it into memory #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use message digest filter streams to limit the required memory during native executable extraction.
Formatter messed up the spacing.
sahilpalvia
approved these changes
Apr 9, 2018
| @Before | ||
| public void before() throws Exception { | ||
| tempDir = File.createTempFile("kpl-unit-tests", ""); | ||
| tempDir.delete(); |
There was a problem hiding this comment.
Should the deletion belong to @after?
There was a problem hiding this comment.
File.createTempFile actually creates the file, but I really want a directory.
Thinking about it I looked for a better solution and found it on Files.createTempDirectory.
Use a method designed to correctly create the temporary directory.
Test cleanup will now cleanup the directory used in testing. It is rather conservative on the clean up to avoid possible issues. This also will check to make sure the all temp files used by the HashedFileCopier are correctly cleaned up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use message digest filter streams to limit the required memory during
native executable extraction.