Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In aws_sdk_eventbridge, there is no pagination helper for ListRules #1205

Open
2 tasks
dcormier opened this issue Oct 9, 2024 · 1 comment
Open
2 tasks
Labels
feature-request A feature should be added or improved. p3 This is a minor priority issue service-api This issue is due to a problem in a service API, not the SDK implementation.

Comments

@dcormier
Copy link

dcormier commented Oct 9, 2024

Describe the feature

Many of the SDK's fluent builders have a method allow the SDK to handle pagination for you. aws_sdk_eventbridge::operation::list_rules::builders::ListRulesFluentBuilder does not. This means you have to manually paginate to retrieve all the rules from the EventBridge ListRules API.

Use Case

Retrieving all the rules when calling the EventBridge ListRules API.

Proposed Solution

Add the documented pagination helper, please.

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

A note for the community

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue, please leave a comment
@dcormier dcormier added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Oct 9, 2024
@landonxjames
Copy link
Contributor

landonxjames commented Oct 10, 2024

Hi @dcormier, thanks for the report! Unfortunately this is not something we in the SDK team can just add. Pagination is modeled in a service's smithy model (see this paginated trait in the dynamo model for an example). Eventbridge would have to update their service model to use the smithy pagination trait so that our code generator for the SDK would know to add a paginator for those APIs.

@jmklix jmklix added p3 This is a minor priority issue service-api This issue is due to a problem in a service API, not the SDK implementation. and removed needs-triage This issue or PR still needs to be triaged. labels Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request A feature should be added or improved. p3 This is a minor priority issue service-api This issue is due to a problem in a service API, not the SDK implementation.
Projects
None yet
Development

No branches or pull requests

3 participants