Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump rustdoc-types to v24 #140

Merged
merged 3 commits into from
Feb 15, 2024
Merged

Bump rustdoc-types to v24 #140

merged 3 commits into from
Feb 15, 2024

Conversation

jayvdb
Copy link
Contributor

@jayvdb jayvdb commented Feb 14, 2024

Issue #, if available:

#130

Description of changes:

  • Bump rustdoc-types to v24 and,
  • fix a typo.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@jayvdb jayvdb requested a review from a team as a code owner February 14, 2024 06:19
@jdisanti
Copy link
Contributor

jdisanti commented Feb 14, 2024

Hey, thanks for taking the time to make this contribution! ❤️

To get CI passing, you'll have to update the Rust nightly version to the version you tested against locally: https:/awslabs/cargo-check-external-types/blob/main/.github/workflows/ci.yml#L17

The README also needs to get updated: https:/awslabs/cargo-check-external-types/blob/main/README.md?plain=1#L37

And the crate will need to be version bumped as well so I can release it: https:/awslabs/cargo-check-external-types/blob/main/Cargo.toml#L3

Copy link
Contributor

@jdisanti jdisanti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jdisanti jdisanti merged commit 65a24af into awslabs:main Feb 15, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants