S3AsyncClient Support #19
Conversation
|
@richardsmithsfdc was glad to discover you've already implemented this! i've taken it and updated it to the current state of |
|
Does the support to AsyncClient has been released? |
It doesn't look like it. @scottgerring made a new PR syncing changes from the latest master at the end of last year, and there has been no movement on that either. I submitted my PR two years ago. It looks like we all have to continue to do what we've been doing, which is to put the async code in our own libraries. |
@ziyanli-amazon , since you committed to this repo last year, is anyone there assigned to look at issues and features? |
|
Let me see if I can try find someone responsible for this too. |
|
@richardsmithsfdc @scottgerring I will take a look next week after i get offcall. |
| this.s3Async = s3Async; | ||
| this.s3BucketName = s3BucketName; | ||
| this.payloadSupport = true; | ||
| LOG.info("Payload support enabled."); |
There was a problem hiding this comment.
Do we wanna add some text to distinguish standard and async s3 clients here?
| * @param s3BucketName Name of the bucket which is going to be used for storing payload. | ||
| * The bucket must be already created and configured in s3. | ||
| */ | ||
| public void setPayloadSupportEnabled(S3AsyncClient s3Async, String s3BucketName) { |
There was a problem hiding this comment.
Does it make sense to have a different method name here?
|
This PR is merged |
Issue #, if available: 17
Description of changes:
This change enables async SQS and S3 client support to be enabled in the Java SQS extended client. I have a companion PR for that repo if this one is accepted.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.