Add from_path() to Target
#122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webern
reviewed
May 14, 2020
This function allows one to get a Target object from a given Path, provided it is a file.
|
Fixed up my booboo's |
zmrow
commented
May 15, 2020
| @@ -224,6 +228,45 @@ pub struct Target { | |||
| pub _extra: HashMap<String, Value>, | |||
| } | |||
|
|
|||
| impl Target { | |||
| /// Given a path, returns a Target struct | |||
| pub fn from_path<P>(path: P) -> Result<Target> | |||
There was a problem hiding this comment.
I should mention that I initially tried to implement TryFrom<AsRef<Path>> and ran into this Rust issue. After that, I didn't think this was worth it to implement TryFrom with String, Path, PathBuf, etc.
iliana
approved these changes
May 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A
Description of changes:
This function allows you to get a Target object from a given Path, provided it is a file.
This code comes from a piece of
tuftool/src/create.rsand will be wholesale removed fromtuftoolin an upcoming PR. I opted to split this small change up into its own PR as the upcoming changes are much much further reaching and this is small and easy to review.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.